path: root/block
diff options
authorFrederic Weisbecker <>2014-02-24 16:40:02 +0100
committerJens Axboe <>2014-02-24 14:47:15 -0800
commitc46fff2a3b29794b35d717b5680a27f31a6a6bc0 (patch)
tree753afca11aeb7dd9b4f70b02a4905f5687e26af3 /block
parentfce8ad1568c57e7f334018dec4fa1744c926c135 (diff)
smp: Rename __smp_call_function_single() to smp_call_function_single_async()
The name __smp_call_function_single() doesn't tell much about the properties of this function, especially when compared to smp_call_function_single(). The comments above the implementation are also misleading. The main point of this function is actually not to be able to embed the csd in an object. This is actually a requirement that result from the purpose of this function which is to raise an IPI asynchronously. As such it can be called with interrupts disabled. And this feature comes at the cost of the caller who then needs to serialize the IPIs on this csd. Lets rename the function and enhance the comments so that they reflect these properties. Suggested-by: Christoph Hellwig <> Cc: Andrew Morton <> Cc: Christoph Hellwig <> Cc: Ingo Molnar <> Cc: Jan Kara <> Cc: Jens Axboe <> Signed-off-by: Frederic Weisbecker <> Signed-off-by: Jens Axboe <>
Diffstat (limited to 'block')
2 files changed, 2 insertions, 2 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 62154ed..6468a71 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -353,7 +353,7 @@ void __blk_mq_complete_request(struct request *rq)
rq->csd.func = __blk_mq_complete_request_remote;
rq-> = rq;
rq->csd.flags = 0;
- __smp_call_function_single(ctx->cpu, &rq->csd);
+ smp_call_function_single_async(ctx->cpu, &rq->csd);
} else {
diff --git a/block/blk-softirq.c b/block/blk-softirq.c
index 6345b7e..ebd6b6f 100644
--- a/block/blk-softirq.c
+++ b/block/blk-softirq.c
@@ -70,7 +70,7 @@ static int raise_blk_irq(int cpu, struct request *rq)
data->info = rq;
data->flags = 0;
- __smp_call_function_single(cpu, data);
+ smp_call_function_single_async(cpu, data);
return 0;