summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Wielaard <mjw@redhat.com>2015-12-02 00:21:07 +0100
committerMark Wielaard <mjw@redhat.com>2016-01-02 20:37:45 +0100
commite04da0e6bab6c6cca2d6e1657d18666f50d2ecfa (patch)
tree06cd08334bb817cb02d7d1d830350b1240830024
parent69d68dd50282469ddc45fc462a2506176b8f3289 (diff)
downloadelfutils-e04da0e6bab6c6cca2d6e1657d18666f50d2ecfa.tar.gz
elfutils-e04da0e6bab6c6cca2d6e1657d18666f50d2ecfa.tar.xz
libdw: Don't use a FDE if it doesn't actually cover a real code range.
If the FDE end <= start then it doesn't actually cover a valid code range. Don't use and cache such FDEs (it will cause memory leaks if there is another FDE that has the same start address and a valid code range). Such FDEs have been seen in the backtrace.ppc.exec testfile. Signed-off-by: Mark Wielaard <mjw@redhat.com>
-rw-r--r--libdw/ChangeLog5
-rw-r--r--libdw/fde.c7
2 files changed, 12 insertions, 0 deletions
diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index b176ade..738e223 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,5 +1,10 @@
2015-12-01 Mark Wielaard <mjw@redhat.com>
+ * fde.c (intern_fde): Don't intern an fde that doesn't cover a
+ valid code range.
+
+2015-12-01 Mark Wielaard <mjw@redhat.com>
+
* dwarf_end.c (dwarf_end): Call cu_free on fake_loc_cu if it exists.
2015-10-14 Chih-Hung Hsieh <chh@google.com>
diff --git a/libdw/fde.c b/libdw/fde.c
index c8475f3..2a59d3e 100644
--- a/libdw/fde.c
+++ b/libdw/fde.c
@@ -90,6 +90,13 @@ intern_fde (Dwarf_CFI *cache, const Dwarf_FDE *entry)
}
fde->end += fde->start;
+ /* Make sure the fde actually covers a real code range. */
+ if (fde->start >= fde->end)
+ {
+ free (fde);
+ return (void *) -1;
+ }
+
fde->cie = cie;
if (cie->sized_augmentation_data)